← til

Commenting your own pull requests when requesting a review

May 3, 2019

I've been practicing reviewing my own pull requests when I open them for some time now, but I've recently learned a trick for improving the reviewing process of a pull request.

Instead of opening a pull request and just requesting a review from people, try adding some comments to the bits that you'd like to get some feedback on. Ask some questions on the most difficult parts, list the trade-offs of your approach, explain why you have done it this way.

This makes reviewing easier since the person that is reviewing can immediately spot the most important parts of the pull request. This guides the person reviewing through the changes you have made and makes their lives easier.

@shime_sh Hrvoje Šimić
0 kudos